Introduce sparsity patterns #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrhill
added
run benchmark
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
- Coverage 90.14% 87.20% -2.95%
==========================================
Files 38 39 +1
Lines 1614 1618 +4
==========================================
- Hits 1455 1411 -44
- Misses 159 207 +48 ☔ View full report in Codecov by Sentry. |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/SparseConnectivityTracer.jl/SparseConnectivityTracer.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/SparseConnectivityTracer.jl/SparseConnectivityTracer.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/SparseConnectivityTracer.jl/SparseConnectivityTracer.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
|
Benchmarks show no regression and the only failing test is JET: I'm not sure what the issue is. EDIT: Should be fixed with ec8a9c3. |
gdalle
requested changes
Jun 27, 2024
src/patterns.jl
Outdated
| ## Fields | ||
| $(TYPEDFIELDS) | ||
| """ | ||
| struct IndexSetVectorPattern{I<:Integer,S<:AbstractSet{I}} <: AbstractVectorPattern |
There was a problem hiding this comment.
I think we can use this PR to remove AbstractSet subtyping (because again, our custom types don't satisfy every assumption) and use duck-typing for that stuff
There was a problem hiding this comment.
My idea is that stuff like DuplicateVector gets to be a DuplicatePattern in the future.
There was a problem hiding this comment.
Okay that's fair. But then we should temporarily remove it from the API if we're gonna change its place in the hierarchy
There was a problem hiding this comment.
You mean before tagging a release?
There was a problem hiding this comment.
Yeah, let's not tag a release where DuplicateVector is an abstract set and then change it right away to a pattern
|
Let's drop I will merge this PR without input size information to avoid feature creep. However, I will refrain from tagging a release without it. |
adrhill
added a commit
that referenced
this pull request
Jun 27, 2024
adrhill
added a commit
that referenced
this pull request
Jul 30, 2024
* Add shared Hessian tracer à la Walther * Add identical objects test * Fixes for patterns introduced in #139 * Clarify connection between mutation and sharing --------- Co-authored-by: adrhill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second attempt at #114 after #119 got derailed by unrelated compile time issues.
This PR introduces
AbstractPatterns that represent sparsity patterns:Over the last dozens of PRs, we've kept refactoring the Tracer type signatures to accommodate new representations for sparse vectors and sparse matrices, most notably:
AbstractSetinterface (Add RecursiveSet and DuplicateVector + better benchmarking of Brusselator #50)Advantages of introducing pattern types:
DictHessianPatterns, which can't be split intogradientandhessianfields.AbstractSetisn't enough, sinceAbstractSets can be used in an allocating or non-allocating manner.In 135, the proposed workaround was to introduce a new field to the
HessianTracerstruct. This is problematic for several reasons:Recommended reading order for reviews:
patterns.jltracers.jl